PHP - mail()

[edesignuk]

Another question...

Any reason why this shouldn't work?

This form:

<form name="contactus" action="/?p=sendmail" method="post">
Query Type<select name="query_type">
<option selected>- Please Select -</option>
<option value="webmaster@thurrocktech.com">Webmaster</option>
<option value="jamie@thurrocktech.com">Jamie</option>
<option value="steve@thurrocktech.com">Steve</option>
</select>
<br/>
Name<input name="name" type="text">
<br/>
Email<input name="email" type="text">
<br/>
Confirm Email<input name="emailc" type="text">
<br/>
Telephone<input name="phone" type="text">
<br/> 
Subject<input name="subject" type="text">
<br/> 
Message<textarea name="emailbody"></textarea>
<br/>
<input type="submit">
</form>

Passes to this page to send:

<?
$to=$_GET['query_type'];
$subject=$_GET['subject'];
$email=$_GET['emailbody'];
$headers="From: ".$_GET['email'];
$mailsend=mail($to,$subject,$email,$headers);
echo "Thank you";
?>

On the face of it, it seems to be working, I don't get any errors or anything. But no mail is coming through

(I know there are elements of the form that don't pass at the moment, just began working on it )

 

[dubbz]

Have you tried setting the various parameters in mail() to something else/static? Eg: Setting '$to' to 'webmaster@thurrocktech.com'. Then repeat for all the params till something happens? It's how I usually troubleshoot.

Been to long since I messed with PHP, so I can't be of much help, but maybe this page can be of more help.

 

[edesignuk]

Thank you muchly dubbz, not quite sure what fixed it, but after looking at the page you linked to I got it working.

Much appreciated!

 

[jim.]

In you first form you send as post. However, in your PHP you are trying to pull your variables from $_GET. Try using $_POST.

Jim

 

[jeremy.king]

Couple other tips - especially if this is exposed to the interweb.

(1) Don't use email addresses in your html forms. Spam bots thrive on this.
(2) Don't use GET, since someone could manipulate URLs and use that form to SPAM
(3) Validate inputs to make sure they came from your site, again to prevent spammers.
(4) Add something to a users session to prevent them from using the form more than once every X minutes.

Good Luck!

 

[edesignuk]

Couple other tips - especially if this is exposed to the interweb.

(1) Don't use email addresses in your html forms. Spam bots thrive on this.
(2) Don't use GET, since someone could manipulate URLs and use that form to SPAM
(3) Validate inputs to make sure they came from your site, again to prevent spammers.
(4) Add something to a users session to prevent them from using the form more than once every X minutes.

Good Luck!

All already done except for number 4

Thanks for the suggestings though everyone.

 

[dhracer88]

I made a pretty simple one that works well, and has a built in check. I'm not all that fluent in PHP though, so I don't know anything about session checks and what not ...